Fixes crash in "percent of correction" feature #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 New build available for commit |
Owner
|
Sounds good. Perhaps also limit the spin button to 5 as the low limit. |
atsju
approved these changes
Jan 7, 2026
Collaborator
Author
I'd love to do that. Are you sure that's okay? No one will ever do 4? I don't really understand the zambuto process very well. |
Collaborator
Author
|
I'm done testing 8.3.0 and I guess I'm not going to wait for Dale to answer my question about the spin button limit so I'm going to merge and do some minor testing and release 8.3.1. |
Owner
|
When using a real Foucault with a mask people do use 4. However this is not real Foucault and they really should do more than 4 zones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this may be crazy because I might be the only person on the planet with these bad registry values. I don't know how I created these registry values but it was just me messing around and testing the feature a while back (maybe a few months?). It's possible that the only version of DFTF that can create these bad registry values was never released but just in case I want this fixed.
Anyway these were my values for 2 items in the registry and they caused a crash:
The code changes in this PR forces DFTF to go to default zones (5 zones with reasonable values) if zones is zero.